New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClojureScript support #17

Merged
merged 1 commit into from Jan 9, 2014

Conversation

Projects
None yet
2 participants
@etehtsea
Contributor

etehtsea commented Jan 9, 2014

I experimented with replacing valip with validateur in modern-cljs guide and everything went fine.

So I added testing under ClojureScript. Hope you like the idea. Feedback is highly appreciated.

P.S. There is one failing test at the moment under cljs and I'm not sure how to properly fix it.

FAIL in (test-format-of-validator-with-optional-message-fn) (:)
expected: (= [false {:id #{[:format {:id "123-abc"} :id ["abc-\\d\\d\\d"]]}}] (v {:id "123-abc"}))
  actual: (not (= [false {:id #{[:format {:id "123-abc"} :id ["abc-\\d\\d\\d"]]}}] [false {:id #{[:format {:id "123-abc"} :id ("/abc-\\d\\d\\d/")]}}]))

michaelklishin added a commit that referenced this pull request Jan 9, 2014

Merge pull request #17 from etehtsea/cljx
Add ClojureScript support

@michaelklishin michaelklishin merged commit fca0b78 into michaelklishin:master Jan 9, 2014

1 check passed

default The Travis CI build passed
Details

@etehtsea etehtsea deleted the etehtsea:cljx branch Jan 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment