Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide pure-floss build flavor #54

Closed
ghost opened this issue Mar 26, 2016 · 10 comments
Closed

Provide pure-floss build flavor #54

ghost opened this issue Mar 26, 2016 · 10 comments
Assignees

Comments

@ghost
Copy link

ghost commented Mar 26, 2016

This app includes Google's proprietary play-services depedency, what is it used for? Could you provide a pure-floss gradle flavor that does not require this (e.g. by stripping functionality or using floss alternatives)?

@anarcat
Copy link

anarcat commented Mar 26, 2016

@krt16s it is used (optionally, not on by default) for GCM notifications, see #37.

is this a blocker for fdroid inclusion (#36)?

@ghost
Copy link
Author

ghost commented Mar 26, 2016

Gradle checks dependency before building, so it will try to find play-services and fail, because we dont have it on the buildserver. I can try to sort things out on our end, but having two separate build flavours is most likely the cleanest way to do it.

@michaelkourlas michaelkourlas added this to the v0.4.2 milestone Apr 12, 2016
@michaelkourlas michaelkourlas self-assigned this Apr 12, 2016
@michaelkourlas
Copy link
Owner

I'll be creating two different builds of the application this summer as part of the v0.4.2 release.

@baldurmen
Copy link

This is really appreciated! Many thanks!

@anarcat
Copy link

anarcat commented Jul 26, 2016

any word on that 0.4.2 release? can't wait!

@michaelkourlas michaelkourlas modified the milestones: v0.5.0, v0.4.2, v0.4.3, v0.4.5 Sep 13, 2016
@michaelkourlas
Copy link
Owner

I've created a special fdroid branch and removed the GCM and billing deps from that branch.

@ghost
Copy link
Author

ghost commented Sep 19, 2016

Thanks, should build tonight: https://gitlab.com/fdroid/fdroiddata/commit/cba5e67c

@michaelkourlas
Copy link
Owner

@krt16s: You might want to remove push notifications from the app description, since the F-Droid version doesn't actually have those (no GCM).

@ghost
Copy link
Author

ghost commented Sep 24, 2016

You are right, should be fixed tomorrow.

@michaelkourlas
Copy link
Owner

@krt16s: You'll also probably want to remove that last "and".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants