Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal integration #55

Closed
anarcat opened this issue Apr 4, 2016 · 8 comments
Closed

signal integration #55

anarcat opened this issue Apr 4, 2016 · 8 comments

Comments

@anarcat
Copy link

anarcat commented Apr 4, 2016

Since I use VoIP.ms, I do not have a cell phone carrier contrat. This means the phone device doesn't actually send SMS messages itself, so I use this app to send my text messages. Unfortunately, since there is no way to set this app to send/receive messages as the default app (#49), it means I have to use two completely different apps depending on which contacts I talk with.

Some contacts, for example, use Signal, and it is much better to talk to them using that app, because the communication is encrypted.

What I would like this app to allow, is for other apps to use it as a messaging app. For example, Signal (or Whatsapp, or Telegram, or whatever) could fallback to the VoIP.ms client instead of the builtin carrier SMS system when they do "insecure" text messaging.

I understand this request may overlap with #49 and show my lack of understanding of Android. For that I apologize, but I figured I would try my luck at scratching that specific itch. :)

@dkisselev
Copy link

Android doesn't really give developers a way to access that part of the subsystem.

Apps can declare themselves as SMS apps, which means that Android will relay messages between the app and the cellphone network subsystem that's built in (so when a message comes in, Android will notify the app with the new message; when you send a message, the app will push the message back to Android, and Android will pass it on to the cellphone networks),

But as you can tell, there's no way to replace that cellphone network component - it's built in to Android, so apps need to integrate with us instead of the other way around. Unfortunately it sounds like Signal has turned down the offer, and I don't think other apps would be willing to put the work in to integrate with a small, highly specific Voip provider.

Technically speaking, it might be possible to implement a replacement for the Android SMS subsystem using Xposed framework, which is a system that you install on your phone that allows apps to override the code of other apps (so you could write an XPosed module that overrides the Android SMS system, intercepts messages and feeds them through Voip.ms). But I think writing a module like that might be a pretty big feat (sending SMS is surprisingly complicated, with lots of nuances and edge cases), not many people have Xposed installed, and even fewer use Voip.ms, so it's unlikely there there would be enough interest to make it happen.

@anarcat
Copy link
Author

anarcat commented Apr 5, 2016

Understood, thanks.

@borfo
Copy link

borfo commented Nov 30, 2016

@michaelkourlas - Posting on this closed issue to point out that it looks like Signal has an API that might allow integration without having to make the Android cell network changes discussed above.

https://github.com/WhisperSystems/Signal-Server/wiki/API-Protocol

@michaelkourlas
Copy link
Owner

Could you clarify how that API would be used to facilitate integration?

@borfo
Copy link

borfo commented Nov 30, 2016

Sorry - looks like that's an old link. Current API docs are here: https://www.whispersystems.org/docs/
I haven't looked too closely at it, but it seems that the signal-service API would allow connection to signal servers via the internet (https) rather than by SMS. I'm not certain whether this would allow connection to Whispersystem's server though - it might require setting up an independent signal server.

Also very possible that I'm an idiot and this wouldn't help with integration at all.

@michaelkourlas
Copy link
Owner

So the idea is basically to embed a Signal client into VoIP.ms SMS? Unfortunately that sounds like it would be a great deal of work; I'm not sure there's enough people who would use it to justify it, especially since there's already a bunch of other stuff on my to-do list.

@borfo
Copy link

borfo commented Nov 30, 2016

Yeah, understood - I just thought I'd point out the existence of the API. Posted here rather than opening a new thread because I figured this may not be a top-of-the-priority list type of thing.

@michaelkourlas
Copy link
Owner

Thanks for the info -- maybe someone will take the initiative and submit a pull request with the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants