New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue that prevented 404 from being sent in GET requests with key #16

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@dougrk
Copy link
Contributor

dougrk commented Jan 2, 2019

Hi! You haven't responded to my other Pull Requests yet. If you think they aren't good, you can just say so. I admit I don't know the "right way" to do things in VBA, but I want to help! This change is really simple! The variable value wasn't declared in that scope, so the TypeName always evaluated as "Empty". It was clear that getValue was intended.

@michaelneu

This comment has been minimized.

Copy link
Owner

michaelneu commented Jan 8, 2019

If you think they aren't good, you can just say so.

Don't worry, if I had something to complain, I would've told you 😄. Also, this is a webserver in VBA, there's not really a "right way", since this is so fundamentally strange. I was just sick since ~ christmas, thus I didn't find the time to look at the PRs.

You're right, that value appears to be an error, good catch!

@michaelneu michaelneu merged commit 4331995 into michaelneu:master Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment