Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all utility commands to setup.py #17

Merged
merged 15 commits into from Jan 11, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Collaborator

commented Jan 11, 2019

This ensures that all the tooling can be run cross-platform (e.g.
Windows doesn't support shell scripts by default).

The change also splits dependencies into development requirements and
runtime requirements. This enables us to provide a smaller footprint
when the library is installed from PyPI.

To test the full end-to-end flow for the library as a user would use it
(i.e., install it from PyPI), this change also switches the Dockerfile
to a multistage build where the first stage runs the linter, tests, etc.
and packages up the module. The second stage then installs the packaged
module and runs the sample which emulates a PyPI install.

c-w added some commits Jan 11, 2019

Move all utility commands to setup.py
This ensures that all the tooling can be run cross-platform (e.g.
Windows doesn't support shell scripts by default).

The change also splits dependencies into development requirements and
runtime requirements. This enables us to provide a smaller footprint
when the library is installed from PyPI.

To test the full end-to-end flow for the library as a user would use it
(i.e., install it from PyPI), this change also switches the Dockerfile
to a multistage build where the first stage runs the linter, tests, etc.
and packages up the module. The second stage then installs the packaged
module and runs the sample which emulates a PyPI install.

@c-w c-w force-pushed the setuppy-ci branch from 883cc13 to e369ec4 Jan 11, 2019

c-w added some commits Jan 11, 2019

@michaelperel michaelperel merged commit c09e13e into refactor Jan 11, 2019

4 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the setuppy-ci branch Jan 11, 2019

@c-w c-w referenced this pull request Jan 11, 2019

Closed

Dockerize Samples #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.