Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all utility commands to setup.py #17

Merged
merged 15 commits into from Jan 11, 2019
Merged

Move all utility commands to setup.py #17

merged 15 commits into from Jan 11, 2019

Conversation

@c-w
Copy link
Collaborator

@c-w c-w commented Jan 11, 2019

This ensures that all the tooling can be run cross-platform (e.g.
Windows doesn't support shell scripts by default).

The change also splits dependencies into development requirements and
runtime requirements. This enables us to provide a smaller footprint
when the library is installed from PyPI.

To test the full end-to-end flow for the library as a user would use it
(i.e., install it from PyPI), this change also switches the Dockerfile
to a multistage build where the first stage runs the linter, tests, etc.
and packages up the module. The second stage then installs the packaged
module and runs the sample which emulates a PyPI install.

c-w added 13 commits Jan 11, 2019
This ensures that all the tooling can be run cross-platform (e.g.
Windows doesn't support shell scripts by default).

The change also splits dependencies into development requirements and
runtime requirements. This enables us to provide a smaller footprint
when the library is installed from PyPI.

To test the full end-to-end flow for the library as a user would use it
(i.e., install it from PyPI), this change also switches the Dockerfile
to a multistage build where the first stage runs the linter, tests, etc.
and packages up the module. The second stage then installs the packaged
module and runs the sample which emulates a PyPI install.
@michaelperel michaelperel merged commit c09e13e into refactor Jan 11, 2019
4 checks passed
@c-w c-w deleted the setuppy-ci branch Jan 11, 2019
@c-w c-w mentioned this pull request Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants