va_copy change causes va_arg functions to break

[michaelrsweet]

Version: 2.10
Original reporter: Steven Warner

I found that va_copy had been changed to copy "&dst from src" instead of original "&dst from &src" this caused functions like mxmlElementSetAttrf to break.

Reinstated the "&dst from &src" which stopped the exception, but still getting a load of heap errors where most if not all of xml output is being kept in memory and not removed from heap.

[michaelrsweet]

Original reporter: Michael Sweet

What OS and compiler are you using?

[michaelrsweet]

Original reporter: Steven Warner

Building for Windows 32bit and 64bit
Using Visual Studio 2010

NOTE: heap errors had increased with 2.10 but the mxmlDelete (bug 551) changes reduced that back to what we previously had. (we've been living with a small memory leak from mxml for a while now - we will have to find the source of it soon though it's getting annoying)

[michaelrsweet]

Original reporter: Steven Warner

Correction:

Found long running leak in our code was result of external client retaining output from mxml.

'va_copy change causes va_arg functions to break' issue still present though

[michaelrsweet]

Will re-test with current Visual Studio, but this looks like a VC++ bug; if VS 2017 still has this issue I'll just add an #ifdef WIN32 and note that this is a Windows bug...

[michaelrsweet]

OK, came up with a solution that eliminates the va_copy on Windows entirely.