Michaeltyson master #153
Closed
Michaeltyson master #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oiding into michaeltyson-master Conflicts: TPKeyboardAvoiding/UIScrollView+TPKeyboardAvoidingAdditions.m
|
Hi! I'd rather not merge this in as it is, because the user may scroll during the edit operation, and if the scroll position is restored to the original after the keyboard is hidden, it may be bewildering to the user. Better to always do the "expected" thing, which is not scrolling to what the user will see as an arbitrary position. Is this to work around a particular issue? |
|
oh, in my App, the scrollview offset has changed after the keyboard hide, so I saved the original offset and restore it when keyboard hide. |
|
Are you able to reproduce it within the sample app, possibly with some changes? |
|
I think I can try it, but maybe need some time. I will comment to you when i finished. |
|
Okay, cool - thank you! You too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restore the scroll offset when keyboard hide