Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.2.4 build with system freeverb3 broken #98

Closed
SpotlightKid opened this issue Mar 4, 2021 · 4 comments
Closed

Version 3.2.4 build with system freeverb3 broken #98

SpotlightKid opened this issue Mar 4, 2021 · 4 comments

Comments

@SpotlightKid
Copy link

The breaking commit seems to be 7657c26. $PKG_CONFIG needs to be in Makefile syntax, i.e. $(PKG_CONFIG) in all plugin Makefiles.

Otherwise you get linking errors:

https://cpaste.org/?fb5dde810cc55fe6#2b6fPWXC9zZurQjCqtoNpHuyjvVD5Z62cjHWFPZFB942

@michaelwillis
Copy link
Owner

@snd1 ^

For what it's worth, I was able to build on Mac and Linux without any trouble. @SpotlightKid Which version of make are you using? If this isn't valid Makefile syntax, then I don't understand why it worked for me at all.

@michaelwillis
Copy link
Owner

@SpotlightKid Does cd8d2e8 fix this?

@SpotlightKid
Copy link
Author

don't understand why it worked for me at all.

Because those lines are only used when you compile with SYSTEM_FREEVERB3="true".

Anyway, seems fixed now.

@snd1
Copy link
Contributor

snd1 commented Mar 5, 2021

argh sorry forgot those brackets facepalm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants