Pasco2 First docs review #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also changed config parameter order
The conversion from optional<bool> to bool return always true, it is needed to call the value member. Co-authored-by: Jonathan Swoboda <154711427+swoboda1337@users.noreply.github.com>
ederjc
approved these changes
Nov 25, 2025
Collaborator
ederjc
left a comment
ederjc
left a comment
There was a problem hiding this comment.
Great!
You could mention in the docs that the measurement interval should not be set lower than 60s for constant operation.
Co-authored-by: J. Nick Koston <nick@koston.org>
* Fix global links * Fix * Fix * Fix legacy rst stuff * Look only for links, ignore code and examples --------- Co-authored-by: Clyde Stubbs <2366188+clydebarrow@users.noreply.github.com>
Owner
Author
|
Perfect, thanks! It's actually mentioned in line 41 of xensiv_pas_co2.md that it should not be below 1 minute per measurement. Maybe I could rephrase it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable):
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rstwhen creating new documents for new components or cookbook.New Component Images
If you are adding a new component to ESPHome, you can automatically generate a standardized black and white component name image for the documentation.
To generate a component image:
Comment on this pull request with the following command, replacing
COMPONENT_NAMEwith your component name in UPPER_CASE format with underscores (e.g.,BME280,SHT3X,DALLAS_TEMP):The ESPHome bot will respond with a downloadable ZIP file containing the SVG image.
Extract the SVG file and place it in the
images/folder of this repository.Use the image in your component's index table entry in
/components/index.rst.Example: For a component called "DHT22 Temperature Sensor", use: