-
Notifications
You must be signed in to change notification settings - Fork 1
fix: make the search case-insensitive #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Fast fix 😄 Everything is fine with the other file "Registering Account" (ReGiSte -> ok). Is there some kind of cache in the system? |
|
It seems the search uses the content inside, not the filename. But then why does it find "emoving"? There is no word "removing" inside. Wonders |
|
Can you paste here the entire content of the file (as code), plus the filename? I will check it out later. |
|
It from forum lonnieezell. https://github.com/lonnieezell/forum-example/tree/develop/help |
|
It should work now. |
neznaika0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine! I don't see where this is implemented, but the content search seems to be working: GENeral -> ok
|
|
||
| $score = 0; | ||
| $score += mb_substr_count($this->getName(), $query); | ||
| $score += mb_substr_count(mb_strtolower($this->getName()), $query); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we check the file name.
|
Thanks for the feedback! |
Description
This PR makes the
searchfunctionality case-insensitive.Fixes #14
Checklist: