Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file DOI check to URL paths #19

Closed
DJRHails opened this issue Sep 8, 2022 · 4 comments · Fixed by #20
Closed

Add file DOI check to URL paths #19

DJRHails opened this issue Sep 8, 2022 · 4 comments · Fixed by #20

Comments

@DJRHails
Copy link
Contributor

DJRHails commented Sep 8, 2022

Often a search can surface DOI descriptors in the URL path alone, for instance:

[pdf2doi]: Performing google search with key "The Experimental Generation of Interpersonal Closeness: A Procedure and Some Preliminary Findings"
[pdf2doi]: and looking at the first 6 results...
[pdf2doi]: Looking for a valid identifier in the search result #1 : https://journals.sagepub.com/doi/pdf/10.1177/0146167297234003
[pdf2doi]: Looking for a valid identifier in the search result #2 : https://journals.sagepub.com/doi/abs/10.1177/0146167297234003

Supporting this would give quicker identifications, but also allow for occasions, such as this, where the DOI can't be extracted from the actual page.

https://doi.org/10.1177/0146167297234003

@MicheleCotrufo
Copy link
Owner

That's an interesting suggestion, thanks! I will implement it in the next version!

@DJRHails
Copy link
Contributor Author

DJRHails commented Sep 8, 2022

I ended up implementing this along with a few other improvements on a fork.

Happy to create a PR to merge upstream if there is interest.

@MicheleCotrufo
Copy link
Owner

Thanks a lot for your efforts!
Yes, can you create the PR? I will check it in detail and approve it within a few days.

@DJRHails
Copy link
Contributor Author

DJRHails commented Sep 9, 2022

See #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants