Don't detect and track DING windows for intellihide #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the dock hides when the desktop window from the DING extension is shown, and the dock is in case IntellihideMode.ALL_WINDOWS:
This proposed fix, excludes the DING extension windows specifically, both the Gtk3 and Gtk4 versions from handled windows, so uses resource usage and takes it out of consideration for any case statement when considering hiding the dock.
This is more specific than #1879 and works in all cases. Also works in conjunction with #1888 which is needed to fix transparency.