Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

added support for the tel: url-scheme #127

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

derflocki commented Sep 12, 2013

This little patch adds support for the tel: url-scheme

Owner

michelf commented Nov 6, 2013

Nice idea. I'm not too sure about the syntax though. If you take the email syntax, you can write it directly without a mailto: prefix (which is what most people do). I'm not sure if this can be done reliably for a phone number though (various places in the world have various formatting, and this might look too much like a tag).

pjt33 commented Dec 18, 2013

Could this not be a one-line diff which adds |tel to the line

$text = preg_replace_callback('{<((https?|ftp|dict):[^\'">\s]+)>}i', 

?

Owner

michelf commented Dec 18, 2013

Eh, that's strange. This pull request should be marked merged, but Github doesn't seem to acknowledge it. It probably has something to do with cherry-picking the commit.

I'm going to close this because it was merged.

@pjt33 The difference with the tel: scheme compared to http and others is that we remove the "tel:" prefix in the link's text content.

@michelf michelf closed this Dec 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment