Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Added composer.json file as described in Issue 31 #42

Closed
wants to merge 1 commit into from

5 participants

@michelf
Owner

Looks like something that'd fit better with the new lib branch I added today. That branch should conform to PSR-0, assuming I haven't done anything wrong.

@simensen

This composer.json will not work as it does not specify the autoloader information required to actually use the classes. I believe the following would need to be added in addition to rebasing agains the lib branch in order for the classes to be usable:

"autoload": {
    "psr-0": { "michelf": "" }
},

@michelf I'm super excited you are moving in this direction. There are a lot of people using my port (dflydev/markdown) and I'd be really excited to be able to reference the official php-markdown distribution as an option instead of maintaining my port indefinitely.

I'd be happy to help on any and all fronts with this! Please let me know if you have any questions on Composer, Packagist, or want help maintaining this package on Packagist once you're ready to publish it there.

@ghost

@michelf - yes, a PSR-0 version would be better. You can always make it BC by having a markdown.php in the root which require's the other two files.

@simensen

@michelf How much work have you been abel to do on the lib branch? Are you close to being able to release that?

@michelf
Owner

I haven't worked much on it. I plan to finalize, annouce, and release it at the same time the next version comes in... Which should be done in less than a month. Technically, there isn't much left to do. Perhaps only adding the composer file.

@michelf
Owner

@drak Backward compatibility on the PHP API side is of no concern in the lib branch. It's a clean break. That's the whole point.

I still need to be able to merge with the other branches however, until they are deprecated. So this puts limits on code refactorings. But the API is a clean break.

@ghost

You know for the php 4 version you can just add a files: require and be done with it.... then worry about the PSR-0 stuff on your lib branch.

"autoload": {
    "files": ["markdown.php"]
}
@ghost Unknown commented on the diff
composer.json
((2 lines not shown))
+ "name": "michelf/php-markdown",
+ "type": "library",
+ "description": "PHP Markdown",
+ "homepage": "http://michelf.com/projects/php-markdown",
+ "keywords": ["markdown"],
+ "license": "BSD-3-Clause",
+ "authors": [
+ {
+ "name": "Michel Fortin",
+ "homepage": "http://michelf.com"
+ },
+ {
+ "name": "John Gruber",
+ "homepage": "http://daringfireball.net"
+ }
+ ],
@ghost
ghost added a note

Missing compatible loader:

"autoload": {
    "files": ["markdown.php"]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jason-gu

Please add composer support, thanks

@michelf
Owner

This has been merged on the lib branch (as discussed earlier). Note, that as this pull request was made against master, github won't close it automatically and won't show it as merged, so I have to close it manually.

@michelf michelf closed this
@baldurrensch baldurrensch deleted the baldurrensch:composer branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 21, 2012
  1. @baldurrensch
This page is out of date. Refresh to see the latest.
Showing with 26 additions and 0 deletions.
  1. +26 −0 composer.json
View
26 composer.json
@@ -0,0 +1,26 @@
+{
+ "name": "michelf/php-markdown",
+ "type": "library",
+ "description": "PHP Markdown",
+ "homepage": "http://michelf.com/projects/php-markdown",
+ "keywords": ["markdown"],
+ "license": "BSD-3-Clause",
+ "authors": [
+ {
+ "name": "Michel Fortin",
+ "homepage": "http://michelf.com"
+ },
+ {
+ "name": "John Gruber",
+ "homepage": "http://daringfireball.net"
+ }
+ ],
@ghost
ghost added a note

Missing compatible loader:

"autoload": {
    "files": ["markdown.php"]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ "require": {
+ "php": ">=4.0.5"
+ },
+ "extra": {
+ "branch-alias": {
+ "dev-master": "1.0-dev"
+ }
+ }
+}
Something went wrong with that request. Please try again.