Skip to content

Michel Fortin
michelf

May 19, 2016
michelf commented on pull request michelf/php-markdown#232
@michelf

The assumption here is that the zip archive is only, or mostly, used on production machines. I'm not really sure this is the case. Also, I wouldn't…

Mar 14, 2016
@michelf
  • @michelf 657d382
    Added history entry about PHPDoc comments.
  • @michelf 6b4f89f
    Merge branch 'issue/98-phpdoc-comments' of git://github.com/robbieave…
  • 1 more commit »
Mar 9, 2016
michelf commented on issue michelf/php-markdown#230
@michelf

Is it the same problem though? The solution in that thread seems to be a mode for parsing only span-level elements, disabling lists, blockquotes, c…

Mar 7, 2016
michelf commented on issue michelf/php-markdown#230
@michelf

Currently I scan the output, check whether the surrounding <p></p>s are the only one in the output and strip them if so - works but hurts my eyes,…

Mar 7, 2016
michelf commented on issue michelf/php-markdown#230
@michelf

Oh! Only parse span-level elements. That would make sense. There's no API for this unfortunately. With some cleverness you could fake it with Markd…

Mar 7, 2016
michelf commented on issue michelf/php-markdown#230
@michelf

I don't think I get it. This is like requesting for > blockquotes not to be enclosed in <blockquote>. How is that useful? Why would you not want yo…

Mar 6, 2016
michelf commented on issue michelf/php-markdown#230
@michelf

Do you mean you don't want paragraph tags anywhere? There is no option for that. Or do you mean that some <p> tags are put somewhere they shouldn't…

Mar 4, 2016
michelf commented on pull request michelf/php-markdown#229
@michelf

This is actually bigger than I expected. It does look good overall. I was surprised that you added documentation for all the callback functions as …

Mar 4, 2016
@michelf
Mar 4, 2016
michelf merged pull request michelf/php-markdown#229
@michelf
[#98] Changing to PHPDoc comments
2 commits with 1,510 additions and 1,062 deletions
Mar 4, 2016
michelf merged pull request michelf/php-markdown#222
@michelf
Optional code span function added
1 commit with 8 additions and 1 deletion
Mar 4, 2016
michelf commented on pull request michelf/php-markdown#229
@michelf

Quick question about @api: shouldn't it apply to public configuration variables too? Or am I mistaken about the signification of this tag?

Mar 3, 2016
michelf commented on pull request michelf/php-markdown#229
@michelf

That should actually be Michel Fortin <michel.fortin@michelf.com>. There's no "a" in my name.

Mar 3, 2016
michelf commented on pull request michelf/php-markdown#229
@michelf

Indeed, can't review this on Github because the diff is too big. I'll take a look at a local copy later today or tomorrow.

Feb 25, 2016
michelf commented on issue michelf/php-markdown#228
@michelf

I can see why someone would want to disallow headers, but I can't really see a reason to disallow code blocks, blockquotes and lists. Maybe we only…

Feb 25, 2016
@michelf
php-markdown作为扩展插件加入MediaWiki后,页面的P标签直接显示了
Feb 25, 2016
@michelf
PHP Markdown Extra parses markdown inside <style> tags
Feb 23, 2016
michelf commented on issue michelf/php-markdown#228
@michelf

Disabling heading and other types of content makes sense. But I'm not sure it's a good idea to make an API that would depend on the internal functi…

Feb 23, 2016
michelf commented on pull request michelf/php-markdown#100
@michelf

If someone wants to do the work of updating the comments, feel free to do so in a new pull request. I'll gladly accept it now that I'm no longer ke…

Feb 23, 2016
michelf commented on issue michelf/php-markdown#227
@michelf

I can't reproduce this on the dingus: it produces the expected output. Are you sure you tested the same example you posted?

Feb 16, 2016
michelf commented on issue michelf/php-markdown#226
@michelf

The Markdown syntax for a line break is to add two spaces at the end of a line. Github is twisting the rules when rendering comments, but not when …

Feb 10, 2016
michelf commented on issue michelf/php-markdown#225
@michelf

There is no direct code highlighting support in PHP Markdown. What you can do is configure the parser to use an external library to do code highlig…

Feb 8, 2016
michelf commented on issue michelf/php-markdown#224
@michelf

That's not supported. But you could create your own subclass of the parser and add a new transformation to the the span gamut that does what you wa…

Feb 5, 2016
michelf commented on pull request michelf/php-markdown#223
@michelf

That makes some sense, but if you're going to replace the text for something else I think it'd be best if it was more explicit. A solution would be…

Feb 5, 2016
michelf commented on pull request michelf/php-markdown#223
@michelf

Interesting. This brings an unexpected behavior: what is in the brackets is usually the link's text and is never replaced by something else. What s…

Feb 5, 2016
michelf commented on pull request michelf/php-markdown#222
@michelf

I think I'll merge this because it makes sense for code highlighting. It also mirrors quite nicely what we already have for code blocks. I'm still …

Feb 4, 2016
michelf commented on pull request michelf/php-markdown#222
@michelf

But are you sure this is a safe way to sanitize user content? This is going to break some part of the markdown syntax that uses <, namely automatic…

Feb 4, 2016
michelf commented on pull request michelf/php-markdown#222
@michelf

Are you using this for syntax highlighting? The code looks fine. I can probably merge this. I just want to know what you're using it for.

Something went wrong with that request. Please try again.