Permalink
Browse files

FLUID-4839: Reducing string concatenation for the aria label containi…

…ng the video title.
  • Loading branch information...
1 parent 4a0fee3 commit b3307c954b84b60ba9c3cd90414f610887f5fd80 @michelled committed Dec 5, 2012
Showing with 3 additions and 3 deletions.
  1. +2 −2 js/VideoPlayer.js
  2. +1 −1 tests/js/VideoPlayerTests.js
View
@@ -264,7 +264,7 @@ https://github.com/fluid-project/infusion/raw/master/Infusion-LICENSE.txt
turnCaptionsOff: "Turn Captions OFF",
transcriptsOff: "Transcripts OFF",
turnTranscriptsOff: "Turn Transcripts OFF",
- videoTitlePreface: "Video"
+ videoTitlePreface: "Video: "
},
selectorsToIgnore: ["overlay", "caption", "videoPlayer", "transcript", "video", "videoContainer"],
keyBindings: fluid.videoPlayer.defaultKeys,
@@ -541,7 +541,7 @@ https://github.com/fluid-project/infusion/raw/master/Infusion-LICENSE.txt
that.container.append(res[key].resourceText);
that.refreshView();
var video = that.locate("video");
- video.attr("aria-label", that.options.strings.videoTitlePreface + ": " + that.options.videoTitle);
+ video.attr("aria-label", that.options.strings.videoTitlePreface + that.options.videoTitle);
// Setting the width and height attributes to respect the CSS API for setting the size of the video
// This is required for cross browser sizing of the video
video.attr("width", video.css("width"));
@@ -135,7 +135,7 @@ https://github.com/fluid-project/infusion/raw/master/Infusion-LICENSE.txt
var testVideoLabel = function (vp, expectedLabel) {
jqUnit.expect(1);
- jqUnit.assertEquals("aria-label should be set properly", vp.options.strings.videoTitlePreface + ": " + expectedLabel, vp.locate("video").attr("aria-label"));
+ jqUnit.assertEquals("aria-label should be set properly", vp.options.strings.videoTitlePreface + expectedLabel, vp.locate("video").attr("aria-label"));
};
videoPlayerTests.asyncTest("Video label: default", function () {

0 comments on commit b3307c9

Please sign in to comment.