Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added js ability within options and tests #52

Merged
merged 2 commits into from Jun 4, 2012

Conversation

Projects
None yet
3 participants
Contributor

nodrog commented Mar 21, 2012

thanks for the gem, just didn't like having to split up the js function calls from the chart options.

Just need to call js_code on a string and it will not escape the string. updated readme with example.

Also added a test to properly format all keys in the hash not just the root keys. And fixed some keys that did not have double quoted strings.

Thanks Andy!
that´s the feature we are waiting for :)

let me check it out , run the specs and see if it´s all right, btw your solution was very neat.

regards!

Contributor

nodrog commented Mar 23, 2012

thanks Miguel,

much appreciate your work on this, really saves me some time... we are just starting a project with quite a lot of charts, do you have any other features you thought would be useful?

Collaborator

xiaods commented Mar 29, 2012

this is good for me.haha, merge ba.

@michelson michelson added a commit that referenced this pull request Jun 4, 2012

@michelson michelson Merge pull request #52 from kujilabs/master
Added js ability within options and tests
87141c2

@michelson michelson merged commit 87141c2 into michelson:master Jun 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment