Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML markup is incorrect in wc_licenses_class.php #38

Closed
k-kikuchi-waverworks opened this issue Sep 10, 2020 · 0 comments
Closed

HTML markup is incorrect in wc_licenses_class.php #38

k-kikuchi-waverworks opened this issue Sep 10, 2020 · 0 comments
Labels

Comments

@k-kikuchi-waverworks
Copy link

k-kikuchi-waverworks commented Sep 10, 2020

Thank you for fixing #33.
I say big thanks to you.

However, this fix caused an another issues.

<td class="slm-view" data-title="<?php echo __('view', 'softwarelicensemanager'); ?>><a href="" class=" woocommerce-button button view"><?php echo _e('view'); ?></a></td>

is incorrect HTML markup.

Please fix this
<td class="slm-view" data-title="<?php echo __('view', 'softwarelicensemanager'); ?>"><a href="" class=" woocommerce-button button view"><?php echo _e('view'); ?></a></td>

You miseed " for data-title attribute.

Also, you missed to add data-title attribute for Order column.

<td class="woocommerce-orders-table__cell woocommerce-orders-table__cell-order-number slm-order"><a href="<?php echo get_site_url() . '/my-account/view-order/' . $license_info->purchase_id_; ?>">#<?php echo $license_info->purchase_id_; ?></a></td>

is should be

<td class="woocommerce-orders-table__cell woocommerce-orders-table__cell-order-number slm-order" data-title="<?php echo __('Order', 'softwarelicensemanager'); ?>"><a href="<?php echo get_site_url() . '/my-account/view-order/' . $license_info->purchase_id_; ?>">#<?php echo $license_info->purchase_id_; ?></a></td>

King Regards
KAZUKI

  • I created pull request about this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants