Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreCompat adapter for NET Core 2.0 #35

Closed
mrgleba opened this issue Aug 22, 2017 · 5 comments
Closed

CoreCompat adapter for NET Core 2.0 #35

mrgleba opened this issue Aug 22, 2017 · 5 comments
Assignees
Milestone

Comments

@mrgleba
Copy link

mrgleba commented Aug 22, 2017

NET Core 2.0 CoreCompat.System.Drawing adapter should reference package CoreCompat.System.Drawing.v2 otherwise there are type name collisions with netstandard2.0 library.

@micjahn
Copy link
Owner

micjahn commented Aug 23, 2017

In my opinion there is a new package needed: ZXing.CoreCompat.System.Drawing.V2
But at the moment the main problem is, that there are some types are missing in CoreCompat.System.Drawing.V2: Rectangle and Color
Color can be replaced with an own implementation. But Rectangle is used by DrawString and LockBits. I have no idea what has to corrected here. Perhaps I'm missing some references.

@mrgleba
Copy link
Author

mrgleba commented Aug 23, 2017

The reason they're missing from CoreCompat.v2 is that they are now part of netstandard 2.0.
So there are no changes in code needed. Just new TargetFramework and a reference to CoreCompat.System.Drawing.v2 rather than CoreCompat.System.Drawing.
I think upgrade to a csproj format would be required for that (at least for that one adapter) (right now I can see project.json stillbeing used everywhere).

@micjahn micjahn self-assigned this Aug 23, 2017
@micjahn micjahn added this to the 0.16.1 milestone Aug 23, 2017
@micjahn
Copy link
Owner

micjahn commented Aug 23, 2017

My mistake. I tried to build it with visual studio 2015. As far as I understand that isn't supported. I made it now with a csproj file and dotnet.exe.

@micjahn micjahn closed this as completed Aug 23, 2017
@micjahn
Copy link
Owner

micjahn commented Aug 24, 2017

Updated package is pushed to nuget. Would be good if somebody can test it.

@mrgleba
Copy link
Author

mrgleba commented Aug 24, 2017

Works perfect.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants