New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running commands with single quotes seems to confuse Attract-Mode #393

Closed
TheDarkula opened this Issue Dec 10, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@TheDarkula

TheDarkula commented Dec 10, 2017

Attract-Mode says that it runs this command:
retroarch -f -L /usr/lib/libretro/mame_libretro.so 'coleco -rp /path/to/coleco -cart "/path/to/rom.7z"'

Which, when I run it in a terminal, plays perfectly. Attract-Mode blips out like it can't parse the path correctly.

I tried wrapping the single-quoted bit in just double quotes, which then ran with Attract-Mode, but then the paths can't have spaces in them.

Thanks so much for the awesome frontend. :)

@TheDarkula

This comment has been minimized.

Show comment
Hide comment
@TheDarkula

TheDarkula Jun 24, 2018

If you point me in the correct direction, I'll work on this.

TheDarkula commented Jun 24, 2018

If you point me in the correct direction, I'll work on this.

mickelson added a commit that referenced this issue Jun 25, 2018

@mickelson

This comment has been minimized.

Show comment
Hide comment
@mickelson

mickelson Jun 25, 2018

Owner

Hey sorry for the delay, there has developed quite a backlog on this project. It looks like this was an error in the code that should be fixed now if you update to the latest master. Please let me know if it isn't working for you

Owner

mickelson commented Jun 25, 2018

Hey sorry for the delay, there has developed quite a backlog on this project. It looks like this was an error in the code that should be fixed now if you update to the latest master. Please let me know if it isn't working for you

@TheDarkula

This comment has been minimized.

Show comment
Hide comment
@TheDarkula

TheDarkula Jun 25, 2018

No worries. It works perfectly now. Thanks so much!
I did have one other unrelated question. Attract-Mode currently omits articles of speech ("The" for example). Is there a toggle for this somewhere I haven't seen?

TheDarkula commented Jun 25, 2018

No worries. It works perfectly now. Thanks so much!
I did have one other unrelated question. Attract-Mode currently omits articles of speech ("The" for example). Is there a toggle for this somewhere I haven't seen?

@mickelson

This comment has been minimized.

Show comment
Hide comment
@mickelson

mickelson Jul 8, 2018

Owner

I'm not sure what you mean about omitting articles of speech.

When attract-mode is scraping and trying to match game names with names from the information source, it does do a couple of tricks including ignoring "the" when matching a name, so that "Simpsons.zip" matches "The Simpsons.zip" for example. Is that what you mean?

Owner

mickelson commented Jul 8, 2018

I'm not sure what you mean about omitting articles of speech.

When attract-mode is scraping and trying to match game names with names from the information source, it does do a couple of tricks including ignoring "the" when matching a name, so that "Simpsons.zip" matches "The Simpsons.zip" for example. Is that what you mean?

@mickelson mickelson closed this Jul 8, 2018

@TheDarkula

This comment has been minimized.

Show comment
Hide comment
@TheDarkula

TheDarkula Jul 8, 2018

Yeah. I had a look at the romlist folder. It's doing stuff like Ninja Warriors, The.cfg I can just go in and change those files manually. Thanks so much!

TheDarkula commented Jul 8, 2018

Yeah. I had a look at the romlist folder. It's doing stuff like Ninja Warriors, The.cfg I can just go in and change those files manually. Thanks so much!

@TheDarkula

This comment has been minimized.

Show comment
Hide comment
@TheDarkula

TheDarkula Jul 9, 2018

Actually, I realised what the problem is. In the .txt for each emulator in the romlists folder, attract-mode disregards the article The. So, for example:

Ninja Gaiden Trilogy;Ninja Gaiden Trilogy;Super Nintendo;;;;;;;;;;;;;;
The Ninja Warriors;The Ninja Warriors;Super Nintendo;;;;;;;;;;;;;;
Nosferatu;Nosferatu;Super Nintendo;;;;;;;;;;;;;;

Whereas The Ninja Warriors;The Ninja Warriors;Super Nintendo;;;;;;;;;;;;;; should be in the "T" section.

TheDarkula commented Jul 9, 2018

Actually, I realised what the problem is. In the .txt for each emulator in the romlists folder, attract-mode disregards the article The. So, for example:

Ninja Gaiden Trilogy;Ninja Gaiden Trilogy;Super Nintendo;;;;;;;;;;;;;;
The Ninja Warriors;The Ninja Warriors;Super Nintendo;;;;;;;;;;;;;;
Nosferatu;Nosferatu;Super Nintendo;;;;;;;;;;;;;;

Whereas The Ninja Warriors;The Ninja Warriors;Super Nintendo;;;;;;;;;;;;;; should be in the "T" section.

@TheDarkula

This comment has been minimized.

Show comment
Hide comment
@TheDarkula

TheDarkula Jul 9, 2018

You might also want to be informed that something very odd is going on with thegamesdb.net's API. Currently none of their /api/*.php pages exist and their wiki hasn't said anything about changes.

TheDarkula commented Jul 9, 2018

You might also want to be informed that something very odd is going on with thegamesdb.net's API. Currently none of their /api/*.php pages exist and their wiki hasn't said anything about changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment