Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout reload when changing display inconsistent #570

Open
zpaolo11x opened this issue Jun 4, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@zpaolo11x
Copy link

commented Jun 4, 2019

If a layout changes display using "fe.set_display(n)" the entire layout is reloaded. When the display is changed using the displays menu or the hot keys the layout is not reloaded and only the lists are updated.

I think both approaches are useful: I have a layout where I want to change displays without reloading everything, since the layout is already reactive. But there might be layouts where one wants to reload the layout each time a display is changed.

There should be a way to do all this: of course one can grab signals for next display and prev display and force layout reload, but there's not a way to select a display and not reloading the layout (except with displays menu)

@oomek

This comment has been minimized.

Copy link
Collaborator

commented Jun 4, 2019

This should be relatively easy to implement by adding a 3rd boolean parameter to reload set_display function set to true as default. Is it that what you need?

@zpaolo11x

This comment has been minimized.

Copy link
Author

commented Jun 4, 2019

If the boolean will allow to change display without reloading the layout then yes, that's what I'd like to have :)

@oomek

This comment has been minimized.

Copy link
Collaborator

commented Jun 4, 2019

Yes that's what I'm thinking about.
Btw, are you on our Discord server yet?
https://discord.gg/NdNkej

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.