[Bug] EnumType duplicated

[ellemedit]

In converting Sequelize.ENUM to GraphQLEnumType
When I called twice same model with EnumType, graphql spits schema duplicated.

[Glavin001]

Could you provide an MCVE ? Thanks.

The applicable code is

graphql-sequelize/src/attributeFields.js

Line 27 in 4826e07

memo[key].type.name = `${Model.name}${key}EnumType`;

and may be a simple fix.

[Glavin001]

I am also experiencing this issue now. I will see what I can do to fix it.

[Glavin001]

I've added a failing unit test to show the existence of this error:

  1) attributeFields should not create multiple enum types with same name:
     Error: Schema must contain unique named types but contains multiple types named "0.09031097055412829enumEnumType".

I'm working on a fix now. I think it will end up being that the fields are cached given an optional argument to attributeFields.

var cache = {};
// First use: Will store in cache
attributeFields(Model, {cache: cache});
// Second use: Will retrieve from cache
attributeFields(Model, {cache: cache});
// No error message

This could also be automatic such that the caching is global for graphql-sequelize. Thus, the cache option would not be required. The disadvantage is that the attributeFields function would not have side effects, the cache.

@mickhansen, what are your thoughts on this?

[mickhansen]

@Glavin001 Under what circumstances does this happen in a real world case?

[mickhansen]

Ah if you reuse a model multiple places that has an Enum type.

[Glavin001]

I apologize that the example in my unit test was rather impractical, however at least it demonstrates the error message.

I think in my case it has to do with using attributeFields in multiple places for generating GraphQL Schema dynamically ( #262, #263 ), which is working fairly well with the exception of ENUM types.

[Glavin001]

Pull request submitted: #272