Refactor details parsing #102

Merged
merged 5 commits into from Jan 8, 2017

Projects

None yet

2 participants

@tobli
Collaborator
tobli commented Jan 8, 2017

Split parsing into several smaller methods, and reduce repetition.

@tobli tobli requested a review from micmro Jan 8, 2017
@tobli
Collaborator
tobli commented Jan 8, 2017

What do you think @micmro? It's a few more lines, but I like that it's broken into smaller pieces.

tobli added some commits Jan 7, 2017
@tobli tobli Refactor timings parsing for details overlay.
No change in logic, just extraction of logic and removal of duplicated logic. Added a FIXME comment about filtering of 0 values. Fix will come in a followup commit.
7a36508
@tobli tobli Refactor response parsing for details overlay.
No change in logic, just extraction of logic.
54cd51f
@tobli tobli Refactor request parsing for details overlay.
No change in logic, just extraction of logic.
0638c61
@tobli tobli Refactor general details for details overlay.
No change in logic, just extraction of logic.
7f89f21
@tobli tobli Add helpers to avoid repeating header names.
This makes lines shorter, and more readable. Also reduces risk of subtle naming errors.
b9081b4
@micmro
micmro approved these changes Jan 8, 2017 View changes

Nice, makes it much easier to visualize!

@micmro micmro merged commit fa909a6 into master Jan 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tobli tobli deleted the details-refactor branch Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment