Show two waterfalls on example page. #106

Merged
merged 1 commit into from Jan 11, 2017

Projects

None yet

2 participants

@tobli
Collaborator
tobli commented Jan 11, 2017

This is two make it easier to catch changes that break multiple waterfalls on the same page. Detected and corrected some minor issues with the example page css to make it work with more than one waterfall.

@tobli tobli requested a review from micmro Jan 11, 2017
@tobli
Collaborator
tobli commented Jan 11, 2017

Not the prettiest code/page, but gets the job done.

src/index.html
var legendHolderEl = document.getElementById("legendHolder")
-
+ function setup(options, fileinputId, outputHolder) {
@micmro
micmro Jan 11, 2017 Owner

looks like the indentation is off here

@micmro
micmro approved these changes Jan 11, 2017 View changes

Could you fix the indentation? Besides looks good.

@tobli tobli Show two waterfalls on example page.
This is two make it easier to catch changes that break multiple waterfalls on the same page. Detected and corrected some minor issues with the example page css to make it work with more than one waterfall.
0da07b5
@tobli
Collaborator
tobli commented Jan 11, 2017

I fixed the indentation, amended, force pushed and will merge now.

@tobli tobli merged commit a1890ea into master Jan 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tobli tobli deleted the two-waterfalls branch Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment