Base lint config on tslint:recommended. #97

Merged
merged 15 commits into from Jan 1, 2017

Projects

None yet

2 participants

@tobli
Collaborator
tobli commented Dec 31, 2016

Update tslint config to start with tslint:recommended and disable the rules we currently don’t comply with. This allows for an incrementally stricter config.

@tobli tobli requested a review from micmro Dec 31, 2016
@tobli
Collaborator
tobli commented Dec 31, 2016

Only mechanical changes to unify style. I don't have much TypeScript experience, but I imaging staying close to the style recommended by Tslint is a good thing. It helps contributors stick to a common style, making patches smaller etc. No controversial changes so far, I guess that'll come when deciding on semicolons or not…

@@ -12,6 +12,7 @@ export function makeLegend(): HTMLUListElement {
<li class="legend-ssl" title="Time required for SSL/TLS negotiation.">SSL (TLS)</li>
<li class="legend-send" title="Time required to send HTTP request to the server.">Send</li>
<li class="legend-wait" title="Waiting for a response from the server.">Wait</li>
- <li class="legend-receive" title="Time required to read entire response from the server (or cache).">Receive</li>`
+ <li class="legend-receive"
+ title="Time required to read entire response from the server (or cache).">Receive</li>`
@micmro
micmro Jan 1, 2017 Owner

Not a biggy: perhaps we should indent this one tab more?

@micmro
micmro approved these changes Jan 1, 2017 View changes

Nice, I had initially followed the Angular2 flavour since I used it at work, but they have realigned as well, so tslint:recommended makes a lot of sense.

Happy new year 🎆 from Korea 🇰🇷!

@micmro micmro merged commit 3d8b5f7 into master Jan 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tobli tobli deleted the tslint-recommended-config branch Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment