New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build WieneckeSinske on Linux #613

Closed
wants to merge 1 commit into
base: mm2
from

Conversation

Projects
None yet
3 participants
@hadim
Copy link
Contributor

hadim commented Mar 6, 2018

No description provided.

@hadim

This comment has been minimized.

Copy link
Contributor

hadim commented Mar 7, 2018

@marktsuchida I just noticed you and @nicost are actively working on MM2 and also switching the build system to Gradle.

This is a very good news!

Please let me know when the build is ok to be tested under Linux so I can adapt this PR to it.

#define snprintf _snprintf
#define snprintf _snprintf
#elif __linux__
#include <arpa/inet.h>

This comment has been minimized.

@kmdouglass

kmdouglass Mar 10, 2018

Contributor

Are these the only lines that are necessary to get the Linux build working? There are a lot of diffs generated by (I assume) the addition/removal of spaces.

This comment has been minimized.

@hadim

hadim Mar 10, 2018

Contributor

Yes they are. Sorry for the formatting issue!

This comment has been minimized.

@kmdouglass

kmdouglass Mar 10, 2018

Contributor

Is there anything that I need to do beyond adding the #include statement to get the Linux build to work? I added the lines you suggest but I still run into the =error: ‘htonl’ was not declared in this scope= error. I checked and I have the inet header on my system, but maybe I need to set an environment variable before building?

EDIT

Ah sorry, I only added the lines to CAN29.cpp. I'll try adding them to WieneckeSinske.cpp as well and try again.

This comment has been minimized.

@hadim

hadim Mar 10, 2018

Contributor

With that script https://github.com/hadim/mm_scripts/blob/master/build-mm.sh you should be able to install MM from a freshly installed Ubuntu.

This comment has been minimized.

@kmdouglass

kmdouglass Mar 10, 2018

Contributor

Thanks! The mistake was mine: I only added the include statement to one of two necessary .cpp files ;) Everything has compiled successfully now.

@nicost

This comment has been minimized.

Copy link
Collaborator

nicost commented Oct 12, 2018

These fixes were pushed to the subversion repository in r16768 and r16767 (sorry for the long delay!). I no longer have the ability to close PRs (or do anything else in the MM repository I guess). Can someone close this PR?

@hadim hadim closed this Oct 13, 2018

@hadim hadim deleted the hadim:fix-linux-build branch Oct 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment