Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is necessary RLock with the GetService? #1076

Closed
wudi opened this issue Jan 2, 2020 · 2 comments
Closed

Is necessary RLock with the GetService? #1076

wudi opened this issue Jan 2, 2020 · 2 comments

Comments

@asim

This comment has been minimized.

Copy link
Member

@asim asim commented Jan 2, 2020

Registry can be replaced during reinitialisation so it needs to be protected

https://github.com/micro/go-micro/blob/master/broker/http_broker.go#L493

@wudi

This comment has been minimized.

Copy link
Contributor Author

@wudi wudi commented Jan 3, 2020

I see.
Thanks asim

@wudi wudi closed this Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.