Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ignore error in method publish #1075

Merged
merged 1 commit into from Jan 3, 2020
Merged

remove ignore error in method publish #1075

merged 1 commit into from Jan 3, 2020

Conversation

@wudi
Copy link
Contributor

wudi commented Jan 2, 2020

Export registry error in method publish.

Show error while service name not found or registry occur some exceptions.

@asim

This comment has been minimized.

Copy link
Member

asim commented Jan 2, 2020

The reason we don't do this is because pubsub is mostly an async thing. Subscribers may not exist before a publisher starts sending messages. Whats the reason for returning the error?

@crazybber

This comment has been minimized.

Copy link

crazybber commented Jan 2, 2020

need an explain @wudi

@wudi

This comment has been minimized.

Copy link
Contributor Author

wudi commented Jan 3, 2020

I think any ready task occur error should export before async.
Just like Marshal error. https://github.com/micro/go-micro/blob/master/broker/http_broker.go#L525

@asim asim merged commit 7098e59 into micro:master Jan 3, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asim

This comment has been minimized.

Copy link
Member

asim commented Jan 3, 2020

Considering we're going to move away from http broker, I'm going to merge and lets see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.