Passing on secret option in config client #1391
Conversation
service/config/client/client.go
Outdated
| nullValue := config.NewJSONValue([]byte("null")) | ||
| req, err := m.client.Get(context.DefaultContext, &proto.GetRequest{ | ||
| Namespace: m.namespace, | ||
| Path: path, | ||
| Secret: o.Secret, |
There was a problem hiding this comment.
If its an option it should be in options
There was a problem hiding this comment.
I will change config endpoint interface then, but tests need this fix as they fail for Ben now.
There was a problem hiding this comment.
BTW, I think we should consider adopting the convention of top level fields for endpoints as
micro config set --secret
Looks better than
micro config set --options.secret
(Config is a bad example here as it's a hardcoded one)
Something to think about, perhaps it's not right and indeed if something is optional it can be prefixed with options on the CLI too.
There was a problem hiding this comment.
When I say add to options I simply mean in the RPC requests. It's being added as an extra field but should mimic other protos that add an options field with Options message type that will contain the secret option. In regards to the CLI behaviour I agree --secret is better.
There was a problem hiding this comment.
I've amended the proto, waiting for builds to pass so we can merge.
No description provided.