Publish tags to NPM #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-carlos
approved these changes
Nov 4, 2019
Collaborator
microbit-carlos
left a comment
microbit-carlos
left a comment
There was a problem hiding this comment.
Fantastic, thanks Matt!
Will do a release now for v0.8.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the minimum we can do to get this published in a repeatable way.
It publishes for version tags only.
It assumes the package.json version number is correct (rather than deriving it from the tag as we've done elsewhere). We can revisit that later. Using automation here would be good if we started publishing @next tagged builds from master, which might help people trying out bug fixes etc.