Add additional recording options #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No slash of text updating while the user can see it.
It's easy to accidentally highlight when going to record
|
Preview build will be at |
microbit-robert
commented
Oct 31, 2024
microbit-robert
commented
Oct 31, 2024
| }, dataWindow.duration); | ||
| if (isRecording) { | ||
| // Set the start recording line | ||
| const now = new Date().getTime(); |
There was a problem hiding this comment.
I'd feel better about this if this could get the timestamps from the code that controls the recording.
Maybe we have a way to listen for recording events that include timestamps rather than using React state.
const recorder = useRecorder()
useEffect(() => {
// With clean-up omitted, events carry a timestamp
recorder.addEventListener("recordingstart", ...)
recorder.addEventListener("recordingstop", ...)
}, [recorder]);
We can look at this in a follow up PR.
Apply same variant to both record buttons for consistency
microbit-robert
commented
Nov 1, 2024
Comment on lines
+118
to
+126
| useEffect(() => { | ||
| if ( | ||
| !recordingDialogDisclosure.isOpen && | ||
| gestures.length === 1 && | ||
| gestures[0].recordings.length === 1 | ||
| ) { | ||
| tourStart(TourId.CollectDataToTrainModel); | ||
| } | ||
| }, [gestures, recordingDialogDisclosure.isOpen, tourStart]); |
Author
There was a problem hiding this comment.
Would have prefered to do this on recording dialog close, but the latest version of the gesture recordings aren't available at that point.
microbit-robert
changed the title
microbit-grace
approved these changes
Nov 1, 2024
microbit-grace
left a comment
microbit-grace
left a comment
There was a problem hiding this comment.
LGTM, not sure if @microbit-matt-hillsdon has anymore comments
microbit-matt-hillsdon
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
userSelect: noneto recording status under recording button