Increase session button focus visible indicator outline #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview build will be at |
|
I think this is OK visually. Let's do a classroom PR alongside this one. |
src/components/NewPageChoice.tsx
Outdated
| onClick(); | ||
| } | ||
| }, [disabled, onClick]); | ||
| const [isFocused, setIsFocused] = useState(false); |
There was a problem hiding this comment.
Feels like there should be a way to do it without this.
Author
There was a problem hiding this comment.
The only other way I can see is a ref, useEffect and listeners on focusin and blur?
Author
There was a problem hiding this comment.
Stateless approach using _groupFocusWithin -> bfc291b
There was a problem hiding this comment.
Thanks! Sorry for my totally non-constructive feedback and glad it turned out to be true.
microbit-matt-hillsdon
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not feel as visually appealing as the current behaviour. Closes #512