Add encoding start and end addresses config data command #9
Conversation
|
Thanks @microbit-carlos. Quick query: why BASE64 rather than just 2 HEX digits? I know BASE64 is more efficient, but I though mapping each byte to two HEX digits would be simpler and more deterministic to compute in DAPLink? i.e. the output data will always be twice as long as the input data... so it's easy to calculate offsets etc when a BLOCK READ request arrives from the USB host? |
|
Yeah, the encoding is still open, I just wrote something down to get the PR up (and one consideration for base64 is the hope that it can be decoded by some browser supported API, to reduce the HTML/JS size). There are more details in Jonny's email if you haven't seen it yet. |
|
Hi @microbit-carlos , I forgot about this repo and instead updated the spec in microbit-foundation/microbit-design@05a25eb. Can you review the changes? Let me know if you need me to raise a PR here with those changes. |
|
Looks fine to me other than checking the use of "base64" in the docs. This will be enough to enable binary file system visualization. Query though: should we also have an end address for this encoding? So specify a "window" which to perform the encoding, rather than assume that the encoding should be done until the end of the file? I don't think we need it right now, but might be useful for future proofing? What do you think @microbit-carlos @gerargz ? |
microbit-carlos
changed the title
|
looks good to me! |
|
Looks good to me as well! 👍 |
|
Awesome, thanks everyone! I'll keep this open in case any tweaks are needed after implementation on the CODAL side. |
|
@gerargz and I don't have bugs. We just have unique behaviour that people haven't discovered yet. ;) |
microbit-carlos
force-pushed
the
base64
branch
from
e93e890 to
d0462cf
Compare
* Add Base64 encoding start address config data command * Update the encoding window storage command to have 2 pointers * Update storage memory layout with the encoding window pointers * Add storage Set encoding window default values * Add additional note about remount needed for some storage commands. * Add Set encoding window to the changelog.
PR for the current proposal.