fix: logout resolves named contexts#420
Open
gyanranjanpanda wants to merge 1 commit into
Open
Conversation
Signed-off-by: gyanranjanpanda <sanupanda141@gmail.com>
79ca6ec to
5446909
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #419.
microcks logoutnow resolves the provided argument as a Microcks context before clearing tokens. That makes the documented named-context flow work for logins created withmicrocks login ... --name <context>, while still preserving the old behavior of accepting the stored user/server name directly.Root cause
login --name stagingstores the user under the server URL and storesstagingonly as the context name.logoutpassed the argument directly toRemoveToken, which searches users by name, somicrocks logout stagingcould not find the token entry.Validation
go test ./cmd -run TestLogoutContext -count=1go test ./pkg/config ./pkg/connectorsgo vet ./cmdNote:
go test ./...is still blocked by the existingTestDeleteContextfixture issue wherecmd/context_test.gowrites./testdata/local.configbefore creatingcmd/testdata.