Repository navigation
Add extraProperties to values and configmap along with 'extra' spring profile so file with extraProperties can be specified in helm install. - #671
Merged
lbroudoux merged 3 commits intoOct 20, 2022
Conversation
carolgschwend
changed the title
lbroudoux
marked this pull request as ready for review
October 20, 2022 15:50
Member
|
This provides a way to fix #528. Thanks a lot @carolgschwend 🙏 |
lbroudoux
approved these changes
Oct 20, 2022
lbroudoux
left a comment
lbroudoux
left a comment
Member
There was a problem hiding this comment.
LGTM! Will just add a condition to switch profile from prod to prod,extra based on the extra.enabled property.
This was referenced Mar 19, 2025
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposing microcks.extraProperties under values file and configuring microcks configmap templating to pull in application properties from a specified yaml file having 'extraProperties' parent key.