Skip to content

Add extraProperties to values and configmap along with 'extra' spring profile so file with extraProperties can be specified in helm install. #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

carolgschwend
Copy link

@carolgschwend carolgschwend commented Sep 27, 2022

Exposing microcks.extraProperties under values file and configuring microcks configmap templating to pull in application properties from a specified yaml file having 'extraProperties' parent key.

@carolgschwend carolgschwend changed the title Add extraProperties to values and configmap so file with extraProperties can be specified in helm install. Add extraProperties to values and configmap along with 'extra' spring profile so file with extraProperties can be specified in helm install. Sep 27, 2022
@lbroudoux lbroudoux self-assigned this Oct 20, 2022
@lbroudoux lbroudoux changed the base branch from master to 1.6.x October 20, 2022 15:42
@carolgschwend carolgschwend temporarily deployed to Build October 20, 2022 15:42 Inactive
@lbroudoux lbroudoux marked this pull request as ready for review October 20, 2022 15:50
@lbroudoux
Copy link
Member

This provides a way to fix #528. Thanks a lot @carolgschwend 🙏

Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will just add a condition to switch profile from prod to prod,extra based on the extra.enabled property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants