Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README says supported versions 1.1–1.9, but .travis.yml tests 1.1–1.11 #80

Closed
dmitshur opened this Issue Mar 14, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@dmitshur
Copy link
Contributor

dmitshur commented Mar 14, 2019

Compare:

bluemonday/README.md

Lines 59 to 63 in 506f3da

### Supported Go Versions
bluemonday is tested against Go 1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 1.7, 1.8, 1.9, and tip.
We do not support Go 1.0 as we depend on `golang.org/x/net/html` which includes a reference to `io.ErrNoProgress` which did not exist in Go 1.0.

bluemonday/.travis.yml

Lines 3 to 13 in 506f3da

- 1.1.x
- 1.2.x
- 1.3.x
- 1.4.x
- 1.5.x
- 1.6.x
- 1.7.x
- 1.8.x
- 1.9.x
- 1.10.x
- 1.11.x

Also, Go 1.12 is out now. Is it supported?

@buro9

This comment has been minimized.

Copy link
Member

buro9 commented Mar 14, 2019

Go 1.12 is supported and works fine (am running it).
However there is a change of behaviour that I'm investigating with data URIs which is triggering a single test failure in Go 1.12.

@buro9

This comment has been minimized.

Copy link
Member

buro9 commented Mar 14, 2019

Found the data URI issue... it was the test that was wrong. The test data URI contain line breaks which is invalid, and net/url in Go1.12 now rejects invalid URIs that contain line breaks including data URIs. Making the test do the right thing made everything happy for Go1.12.

@buro9 buro9 closed this Mar 14, 2019

@dmitshur

This comment has been minimized.

Copy link
Contributor Author

dmitshur commented Mar 14, 2019

Thanks!

@buro9

This comment has been minimized.

Copy link
Member

buro9 commented Mar 14, 2019

And now Go1.1 fails on me 🙄
https://travis-ci.org/microcosm-cc/bluemonday/builds/506418076

I may just remove this 😆

@buro9

This comment has been minimized.

Copy link
Member

buro9 commented Mar 14, 2019

Yeah... removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.