New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go Modules #77

Merged
merged 1 commit into from Dec 22, 2018

Conversation

Projects
None yet
2 participants
@SamWhited
Copy link
Contributor

SamWhited commented Dec 22, 2018

Hello,

Please consider supporting Go Modules, the new packaging standard that will be adopted fully in Go 1.12. Experimental support is in Go 1.11 and the new module paths are supported in Go 1.9.7+ and Go 1.10.3+ in a read-only manner for backwards compatibility with all supported versions of Go.

Because this library is still below version 2 and has few dependencies, the go.mod file is fairly simple. The only other thing that would need to be done if this PR were merged is to create a semver compatible tag (eg. v1.0.2) that users of this library can pin to.

Note that I set the language version go 1.9 in the mod file because 1.9.7 is the earliest version with partial support for reading the go.mod file. If you want to continue to support syntax and APIs from as early as 1.1, I can change it, but the tooling doesn't actually understand these versions yet so to start I just set it to 1.9.

Thank you for your consideration.

@buro9 buro9 merged commit 506f3da into microcosm-cc:master Dec 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@buro9

This comment has been minimized.

Copy link
Member

buro9 commented Dec 22, 2018

Done, looks sane.

Q: Is there a tool that will update future dependencies and that go.sum file? Or is this done manually?

@SamWhited

This comment has been minimized.

Copy link
Contributor Author

SamWhited commented Dec 22, 2018

Thanks! Just running go build will update based on any files it touches. To remove unused stuff or add stuff in build tags and what not that would be skipped by a build go mod tidy can be used

@SamWhited

This comment has been minimized.

Copy link
Contributor Author

SamWhited commented Dec 22, 2018

Oh, and go get -u in module mode will bump versions as you'd expect.

@SamWhited SamWhited deleted the SamWhited:support_modules branch Dec 22, 2018

@buro9

This comment has been minimized.

Copy link
Member

buro9 commented Dec 22, 2018

Perfect, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment