Repository navigation
Move quoteback-component styles from inline HTML to main CSS file - #13
Merged
Merged
Conversation
This change relocates the `quoteback-component` block styles from `layouts/_default/baseof.html` to `static/css/main.css` to keep styling in the stylesheet and remove a validation error from having it in the `<body>`. This has a downside: If someone has used `microhook-uncss.html`, now this style won’t be defined for them. I think this is ok—the component still shows up, it just doesn’t have these nicer styles. There’s an upside too: Now that these styles are in the `main.css`, they’re easier to override without `!important` in a user’s `custom.css`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change relocates the
quoteback-componentblock styles fromlayouts/_default/baseof.htmltostatic/css/main.cssto keep styling in the stylesheet and remove a validation error from having it in the<body>.This has a downside: If someone has used
microhook-uncss.html, now this style won’t be defined for them. I think this is ok—the component still shows up, it just doesn’t have these nicer styles.There’s an upside too: Now that these styles are in the
main.css, they’re easier to override without!importantin a user’scustom.css.This change can be seen live here: https://web.chasen.dev/2025/06/18/one-of-the-things-i.html