replace calls to find_all with custom traversal #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bs4.find and find_all seem to be unduly expensive operations. just replacing them with naive get_children and get_descendants calls cuts the parse time in half for lots of documents.
|
this seems to have a reduced average parse times on Bridgy from ~300ms to ~150ms |
|
ping @tommorris? can't wait to use this (released properly) in bridgy. i'd also nominate/second adding @kylewm as a committer to the repo if you're taking suggestions. :P |
|
@snarfed oh lol, I already am. |
kylewm
pushed a commit
that referenced
this pull request
Mar 21, 2016
replace calls to find_all with custom traversal
|
released version 1.0.4 https://pypi.python.org/pypi/mf2py/1.0.4 |
snarfed
added a commit
to snarfed/bridgy
that referenced
this pull request
Mar 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bs4.find and find_all seem to be unduly expensive operations.
just replacing them with naive get_children and get_descendants
calls cuts the total parse time in half for lots of documents.
Parsing kylewm.com went from around 130ms to 66ms
(epeus.blogspot.com and chocolateandvodka.com -- backcompat
tests -- are about the same), the very large page at
rhiaro.co.uk/travel from 780ms to 420ms
Ref #63