New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0 complete rewrite #59

Merged
merged 18 commits into from May 12, 2017

Conversation

Projects
None yet
2 participants
@dissolve
Collaborator

dissolve commented May 11, 2017

hmm thought i had privileges to review, it seems not.

@dissolve dissolve requested a review from veganstraightedge May 11, 2017

@veganstraightedge

I left the same comment in a few places, but it can be applied everywhere. I think this is a good time to move to almost/all named parameters since it's already a big breaking change release.

Also, I don't love the test suite requiring npm. I understand why you did it. It's pragmatic. But I'd like to see this get moved over to a ruby/rake workflow in the future.

Show outdated Hide outdated lib/microformats2/format_parser.rb
Show outdated Hide outdated lib/microformats2.rb
Show outdated Hide outdated lib/microformats2/parser.rb
Show outdated Hide outdated lib/microformats2/results/collection.rb
Show outdated Hide outdated lib/microformats2/results/collection.rb

dissolve added some commits May 12, 2017

code clean up
missed a few tabbing issues
more consistant spacing
changed all functions to be named parameters after the first
 this should have been changed when that change was first made, but
 this now adds a min version for ruby of 2.0
 when named params first introduced

@veganstraightedge veganstraightedge merged commit f3b3f6e into master May 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@veganstraightedge veganstraightedge deleted the 3-rebase branch May 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment