New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTML id parsing proposal #207

Merged
merged 5 commits into from Dec 25, 2018

Conversation

Projects
None yet
3 participants
@sknebel
Copy link
Member

sknebel commented Nov 18, 2018

@sknebel sknebel requested a review from gRegorLove Nov 19, 2018

@Zegnat
Copy link
Member

Zegnat left a comment

This looks like a straight forward enough change! Just the one little nitpick.

Also wondering if we should some edge-case tests? The following come to mind:

  1. id="0" – to make sure the falsy test is correct; and
  2. id="" – though we need to decide whether this gets added to the parsed object or not. I think not.
Show resolved Hide resolved Mf2/Parser.php Outdated
id parsing: explicitly check id against empty string
Co-Authored-By: sknebel <sknebel@users.noreply.github.com>

@dshanske dshanske referenced this pull request Nov 19, 2018

Closed

fetch_feeds notes #20

@sknebel

This comment has been minimized.

Copy link
Member

sknebel commented Nov 19, 2018

Can add the test cases. Agreed id="" shouldn't be in the result - id "must contain at least one character". Will update the spec text proposal to reflect this.

@Zegnat

Zegnat approved these changes Nov 19, 2018

Copy link
Member

Zegnat left a comment

LGTM! Just waiting for Travis to also turn up green on the tests.

@gRegorLove

This comment has been minimized.

Copy link
Member

gRegorLove commented Nov 20, 2018

I'd suggest trim($e->getAttribute('id')) !== '' to cover any authoring whitespace mistakes like id=" ". Otherwise LGTM!

@sknebel sknebel force-pushed the sknebel:implement-id-proposal branch from e23f0a3 to 10ea6b6 Nov 20, 2018

@gRegorLove
Copy link
Member

gRegorLove left a comment

👍

@Zegnat Zegnat merged commit 14e8c5e into microformats:master Dec 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Zegnat

This comment has been minimized.

Copy link
Member

Zegnat commented Dec 25, 2018

I went ahead and merged this. As I had already completely forgotten about it… Letting reviewed patches sit and get stale seems wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment