New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce instances where photo is implied #210

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@gRegorLove
Copy link
Member

gRegorLove commented Nov 21, 2018

Fixes #198

@gRegorLove gRegorLove requested review from Zegnat and aaronpk Nov 21, 2018

@Zegnat
Copy link
Member

Zegnat left a comment

As there is talk with putting the proposed resolution in the spec already, lets move on this.

@@ -1090,7 +1090,7 @@ public function parseH(\DOMElement $e, $is_backcompat = false, $has_nested_mf =
}
// Check for u-photo
if (!array_key_exists('photo', $return) && !$is_backcompat) {
if (!array_key_exists('photo', $return) && !in_array('u-', $prefixes) && !$is_backcompat) {

This comment has been minimized.

@Zegnat

Zegnat Dec 25, 2018

Member

Does this also require !$has_nested_mf as part of the if statement? If so, lets add it as well as a matching test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment