Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the new rel-urls key is making mf2py fail all the tests #16

Closed
kevinmarks opened this issue May 23, 2015 · 3 comments
Closed

the new rel-urls key is making mf2py fail all the tests #16

kevinmarks opened this issue May 23, 2015 · 3 comments

Comments

@kevinmarks
Copy link
Member

@kevinmarks kevinmarks commented May 23, 2015

Should I add it to the results and send a pull request?

http://testrunner-47055.onmodulus.net/run/mf2py/all/

background: http://microformats.org/wiki/microformats2-parsing-brainstorming#more_information_for_rel-based_formats

@glennjones
Copy link
Member

@glennjones glennjones commented May 23, 2015

Hi Kevin

I am not sure if it should be part of the main microformat-v2 tests group at the moment.

I consider anything that makes onto parsing rules page http://microformats.org/wiki/microformats2-parsing to be the strict structure of output. Once its talked through with community and its gets agreement to be move from brainstorming to parsing rules, then fine it should be in there.

For now we could add it as experimental group to the tests. i.e. a new directory in 'tests' call experimental with pairs of HTML and JSON files for each test.

pull-request with test would help. If its a new test group can you also add a change-log.html file along the line of whats already there. I am going to write up a little guide for contribution soon.

I will also look at way of allow parsers to support new experimental top level structures without all the tests throwing errors

@tantek
Copy link
Member

@tantek tantek commented May 25, 2015

Noting this issue on the brainstorming doc - so I can resolve it once I've made the edit to microformats2-parsing.

@glennjones
Copy link
Member

@glennjones glennjones commented Jun 1, 2015

Tantek moved rel-urls into the parser instruction and out of brainstorming, so they are in the latests tests

@glennjones glennjones closed this Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants