New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
microG Settings in AppInfo and SystemSettings (+ adaptive icon) #719
microG Settings in AppInfo and SystemSettings (+ adaptive icon) #719
Conversation
@@ -0,0 +1,5 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the source and license of this icon? Looks like it could be an original Google file (even though it's not very complex), so please verify it is not or at least properly licensed. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I just accepted the pull request over at my fork without further checking. I'll create a new drawable from the official microG icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added new drawable based on artwork/ic_microg_settings.svg, should be fine now.
…ased on artwork/ic_microg_settings.svg
@ale5000-git https://github.com/Vavun/android_packages_apps_GmsCore/blob/patch-5/%D0%A1%D0%BD%D0%B8%D0%BC%D0%BE%D0%BA.PNG https://github.com/Vavun/android_packages_apps_GmsCore/tree/patch-5 PS |
@Vavun: |
@ale5000-git just see compare like this master...Vavun:patch-5 My fork is a fork of Nanolx fork with some branches with pull requests to vanila microg I never use github before this so I am afraid to touch anything not to completely break everything. Sorry for mess and bad english |
Currently the main problem is: what is the license of the images you added? |
@ale5000-git I took them here |
@Vavun you may re-base your fork on the last stable version:
and then you can |
I'll rebase my fork this weekend and sent in pull requests - sorry for the delay. |
Show microG Settings not just in Launcher, but also in
Also includes Adaptive icon and updated strings.xml for C, de and ru.
This commit is the result of manually squashed commits by me and @Vavun found in my fork's master branch. Reportedly working according to all testers accross different Android versions.
[I'm really sorry... but I wanted a clean pull request but somehow I've managed to mess up submodules twice]