From 07fb4978ec519eefcb7b5c1dc4e509e2b6ebcd84 Mon Sep 17 00:00:00 2001 From: Kiko Beats Date: Mon, 10 Sep 2018 13:52:22 +0200 Subject: [PATCH] Add docs --- README.md | 16 ++++++++++++++++ src/browserless.js | 11 +++++++++-- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index cb94b6d689..4a2c6a5362 100644 --- a/README.md +++ b/README.md @@ -84,6 +84,22 @@ https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#puppeteerlaunc By default the library will be pass a well known list of flags, so probably you don't need any additional setup. +##### timeout + +type:`number`
+default: `30000` + +This setting will change the default maximum navigation time. + +##### incognito + +type:`boolean`
+default: `true` + +Every time a new page is created, it will be an incognito page. + +An incognito page will not share cookies/cache with other browser pages. + ### .pool(options) Tha main **browserless** constructor expose a singleton browser. This is enough for most scenarios, but in case you need you can intialize a **pool of instances**. diff --git a/src/browserless.js b/src/browserless.js index a4a3b7e65c..b8795048a3 100644 --- a/src/browserless.js +++ b/src/browserless.js @@ -36,7 +36,11 @@ const createTempFile = opts => { // The puppeteer launch causes many events to be emitted. process.setMaxListeners(0) -module.exports = launchOpts => { +module.exports = ({ + incognito = true, + timeout = 30000, + ...launchOpts +} = {}) => { let browser = puppeteer.launch({ ignoreHTTPSErrors: true, args: [ @@ -59,8 +63,11 @@ module.exports = launchOpts => { const newPage = () => Promise.resolve(browser).then(async browser => { - const context = await browser.createIncognitoBrowserContext() + const context = incognito + ? await browser.createIncognitoBrowserContext() + : browser const page = await context.newPage() + page.setDefaultNavigationTimeout(timeout) return page })