From e53be2fd0f683dfdd80b07d9f64de7b102cd3707 Mon Sep 17 00:00:00 2001 From: Kiko Beats Date: Fri, 25 Jan 2019 18:03:58 -0500 Subject: [PATCH] build: update youtube-dl (#152) * build: update youtube-dl * test: remove unreachable link --- packages/metascraper-media-provider/package.json | 2 +- .../src/get-media/get-media.js | 5 ++--- packages/metascraper-media-provider/test/index.js | 10 ++-------- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/packages/metascraper-media-provider/package.json b/packages/metascraper-media-provider/package.json index 387660ed3..7cbde4899 100644 --- a/packages/metascraper-media-provider/package.json +++ b/packages/metascraper-media-provider/package.json @@ -24,7 +24,7 @@ "memoize-token": "~1.1.3", "p-reflect": "~1.0.0", "tunnel": "0.0.6", - "youtube-dl": "~1.12.2" + "@microlink/youtube-dl": "~1.13.0" }, "devDependencies": { "browserless": "latest", diff --git a/packages/metascraper-media-provider/src/get-media/get-media.js b/packages/metascraper-media-provider/src/get-media/get-media.js index c8435d62f..147889137 100644 --- a/packages/metascraper-media-provider/src/get-media/get-media.js +++ b/packages/metascraper-media-provider/src/get-media/get-media.js @@ -1,6 +1,6 @@ 'use strict' -const youtubedl = require('youtube-dl') +const youtubedl = require('@microlink/youtube-dl') const { promisify } = require('util') const { noop } = require('lodash') @@ -23,8 +23,7 @@ module.exports = ({ cacheDir, onError = noop } = {}) => { url, isTwitterUrl(url) && PROXY_URL ? [...opts, `--proxy=${PROXY_URL}`] - : opts, - { maxBuffer: Infinity } + : opts ) } catch (err) { onError(err, url) diff --git a/packages/metascraper-media-provider/test/index.js b/packages/metascraper-media-provider/test/index.js index c265f04cf..bbf53169e 100644 --- a/packages/metascraper-media-provider/test/index.js +++ b/packages/metascraper-media-provider/test/index.js @@ -61,10 +61,7 @@ describe('metascraper-media-provider', () => { }) describe('youtube', () => { - ;[ - 'https://www.youtube.com/watch?v=gABW21GkFw8', - 'https://www.youtube.com/watch?v=hwMkbaS_M_c' - ].forEach(url => { + ;['https://www.youtube.com/watch?v=hwMkbaS_M_c'].forEach(url => { it(url, async () => { const metadata = await metascraper({ url }) console.log(metadata.video) @@ -113,10 +110,7 @@ describe('metascraper-media-provider', () => { describe('audio', () => { describe('youtube', () => { - ;[ - 'https://www.youtube.com/watch?v=gABW21GkFw8', - 'https://www.youtube.com/watch?v=hwMkbaS_M_c' - ].forEach(url => { + ;['https://www.youtube.com/watch?v=hwMkbaS_M_c'].forEach(url => { it(url, async () => { const metadata = await metascraper({ url }) console.log(metadata.audio)