Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't recognize a metascraperrc/package.json OR looks for them in a different path when running from node_modules? #52

Closed
coolreader18 opened this issue Jan 19, 2018 · 2 comments

Comments

@coolreader18
Copy link

coolreader18 commented Jan 19, 2018

I have a package published that uses metascraper, yet it doesn't seem to draw from either a metascraperrc or the metascraper section of package.json, when it's in node_modules. It works when testing in its own directory, but not as a package. Am I doing something wrong, or is this a scoping issue? It could also be that I'm using a local rule, such as ./rule.js, which it might be looking for in the root directory of the project that has it as its dependency.

@Kikobeats
Copy link
Member

Could be easy to reproduce setup a package.json with metascraper property here instead of use the rc file:

https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper/test/unit/custom-rules

@Kikobeats
Copy link
Member

I added METASCRAPER_CWD documentation for do that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants