ISSUE-116: Broken RegExp for pattern with noext option

[mrmlnc]

Links

• Broken RegExp for pattern with noext option #116
• No match found when pattern contains parentheses sindresorhus/globby#74

What is?

When we work with the text node – we shouldn't add a backward slash before it.

For example, the following pattern:

./test(dir)/foo.txt

Before fix:

/^(?:(?:(?:\.(?:\/|\\))(?=.))?test\(\dir\)\/foo\.txt)$/

After fix:

-/^(?:(?:(?:\.(?:\/|\\))(?=.))?test\(\dir\)\/foo\.txt)$/
+/^(?:(?:(?:\.(?:\/|\\))(?=.))?test\(dir\)\/foo\.txt)$/

Questions

• Sorry but I don't understand where I should add the new test 😭

[jonschlinkert]

Hi, thanks for the pr! There is an extglob edge case that will break with this change, I'm not sure why travis is passing, it's failing locally for me.

If we update that code to only escape parens and non-word characters everything will work as expected:

  compiler.set('paren', function(node) {
    var val = '';
    visit(node, function(tok) {
      if (tok.val) val += (/^\W/.test(tok.val) ? '\\' : '') + tok.val;
    });
    return this.emit(val, node);
  });

Sorry but I don't understand where I should add the new test

You added the test to the right place, thanks!

Do you want to update your PR? If not I can push it up.

[jonschlinkert]

Note that globby does not use micromatch.

[mrmlnc]

it's failing locally for me.

I have no any problems locally on the macOS with Node.js 9.5.0.

Do you want to update your PR?

Done.

Note that globby does not use micromatch.

Now the globby package uses fast-glob package that uses micromatch :P

[jonschlinkert]

Now the globby package uses fast-glob package that uses micromatch :P

ah! I missed that! thanks!

Btw the failures are expected. I just optimized a couple regexps in nanomatch, I just need to update those unit tests.