Remove isodd #11
Merged
Remove isodd #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rehevkor5
reviewed
Mar 30, 2018
lib/parsers.js
Outdated
| var val = m[0]; | ||
|
|
||
| var isNegated = isOdd(val.length); | ||
| var isNegated = Math.abs(val.length%2)==1; |
There was a problem hiding this comment.
This change is great, but I doubt you need to worry about strings with negative length :)
There was a problem hiding this comment.
Yeah just being careful. I can take out the Math.abs if you want :)
There was a problem hiding this comment.
It seems like being careful is how we got to isOdd in the first place.
doowb
requested changes
Mar 30, 2018
lib/parsers.js
Outdated
| var val = m[0]; | ||
|
|
||
| var isNegated = isOdd(val.length); | ||
| var isNegated = ((val.length%2)==1); |
There was a problem hiding this comment.
Nitpicks:
- remove the outer parentheses
- put spaces before and after the
%and the== - use strict equal
===
Basically: var isNegated = (val.length % 2) === 1;
|
This looks identical to the patch in #7. |
stupidgamesinhtml
approved these changes
Mar 31, 2018
doowb
approved these changes
Mar 31, 2018
|
@tonetheman thanks for the PR! /cc @jonschlinkert @phated @es128 if there are no objects, I think this can be published as a patch bump. |
|
ftr, this is the last PR that will be accepted for is-odd or is-even. we don't have time for trolls. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed is-odd from your dependencies. It looked like you used an npm package called is-odd.
It felt like you might not need a package to do that small of a test. No worries if you choose not to take the PR.
After my change I checked that all tests still passed. I did not add any new tests since the change looked like it would be tested during the negate portion of your existing tests.