Issue 4306 - Bean validation should fail if @Valid field is not introspected #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spected - emit validation failure when @Valid alone is applied to a container of elements where the element type is not @introspected. - this does not address cases with additional constraint(s), since that might still be legal if the element type is supported by those constraints directly (e.g. @Valid @SiZe(min=1, max=2) List<String> strs), even though something like @Valid @SiZe(min=1, max=2) List<NotIntrospected> oops might be bogus.
This was referenced Oct 29, 2020
jameskleeh
reviewed
Oct 29, 2020
validation/src/main/java/io/micronaut/validation/validator/DefaultValidator.java
Outdated
Show resolved
Hide resolved
…spected - emit validation failure when @Valid alone is applied to a container of elements where the element type is not @introspected. - this does not address cases with additional constraint(s), since that might still be legal if the element type is supported by those constraints directly (e.g. @Valid @SiZe(min=1, max=2) List<String> strs), even though something like @Valid @SiZe(min=1, max=2) List<NotIntrospected> oops might be bogus.
…spected - emit validation failure when @Valid alone is applied to a container of elements where the element type is not @introspected. - this does not address cases with additional constraint(s), since that might still be legal if the element type is supported by those constraints directly (e.g. @Valid @SiZe(min=1, max=2) List<String> strs), even though something like @Valid @SiZe(min=1, max=2) List<NotIntrospected> oops might be bogus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 4306 - Bean validation should fail if @Valid field is not introspected
@Validalone is applied to a container of elements where the element type is not@Introspected.@Valid @Size(min=1, max=2) List<String> strs), even though something like@Valid @Size(min=1, max=2) List<NotIntrospected> oopsmight be bogus.